Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GHC 9.4 to version 9.4.6 #1998

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Bump GHC 9.4 to version 9.4.6 #1998

merged 2 commits into from
Nov 13, 2023

Conversation

avdv
Copy link
Member

@avdv avdv commented Oct 25, 2023

depends on #1994

@avdv avdv changed the title Update nixpkgs used in start script to revision 23.05 Bump GHC 9.4 to version 9.4.6 Oct 25, 2023
@avdv avdv force-pushed the upgrade-ghc-9.2.8 branch 2 times, most recently from 230823a to 865a428 Compare November 8, 2023 09:29
Base automatically changed from upgrade-ghc-9.2.8 to master November 9, 2023 09:04
@dpulls dpulls
Copy link

dpulls bot commented Nov 9, 2023

🎉 All dependencies have been resolved !

@avdv
Upgrade GHC 9.4 to version 9.4.6
bad1b9b 
* use GHC 9.4.6 in CI workflows
* upgrade stack resolver to 21.11 and re-pin
@avdv avdv marked this pull request as ready for review November 13, 2023 08:16
@avdv avdv requested a review from ylecornec November 13, 2023 08:16
ylecornec
ylecornec approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@ylecornec ylecornec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. But it seems that the CI is still expecting the tests for the 9.4.5 to complete.

@avdv
Copy link
Member Author

avdv commented Nov 13, 2023

It looks good to me. But it seems that the CI is still expecting the tests for the 9.4.5 to complete.

Thank you. Yes, I'll change the branch config before merging...

@avdv avdv added the merge-queue merge on green CI label Nov 13, 2023
@mergify mergify bot merged commit 0c66e7a into master Nov 13, 2023
114 checks passed
@mergify mergify bot deleted the ghc-9.4.6 branch November 13, 2023 10:52
@mergify mergify bot removed the merge-queue merge on green CI label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylecornec ylecornec ylecornec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avdv @ylecornec